Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: Sending message when choose emoji from ComposerPopupBox #32886

Closed
wants to merge 1 commit into from
Closed

regression: Sending message when choose emoji from ComposerPopupBox #32886

wants to merge 1 commit into from

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jul 24, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

Fix message being sent by "Enter" key when choosing a emoji from ComposerPopupBox list

Introduced: #32861

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 54fe110

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@tiagoevanp tiagoevanp marked this pull request as ready for review July 24, 2024 04:38
@tiagoevanp tiagoevanp requested a review from a team as a code owner July 24, 2024 04:38
@tiagoevanp tiagoevanp changed the title regression: Sending message when choosing an emoji from ComposerPopupBox regression: Sending message when choose emoji from ComposerPopupBox Jul 24, 2024
@tiagoevanp tiagoevanp force-pushed the regression/composer branch 3 times, most recently from b71baf1 to b5c5b51 Compare July 24, 2024 04:41
@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.45%. Comparing base (05db8aa) to head (54fe110).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32886      +/-   ##
===========================================
- Coverage    55.50%   55.45%   -0.06%     
===========================================
  Files         2637     2636       -1     
  Lines        57289    57368      +79     
  Branches     11859    11882      +23     
===========================================
+ Hits         31797    31812      +15     
- Misses       22801    22857      +56     
- Partials      2691     2699       +8
Flag Coverage Δ
e2e 54.02% <33.33%> (-0.09%) ⬇️
unit 72.18% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo
Copy link
Member

ggazzo commented Jul 24, 2024

could you please add when this was introduced?

@tiagoevanp tiagoevanp marked this pull request as draft July 24, 2024 14:57
@tiagoevanp tiagoevanp closed this Jul 24, 2024
@tiagoevanp
Copy link
Contributor Author

Closed in favor of #32890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagoevanp @ggazzo